Messages in this thread | | | Subject | Re: [PATCH v8 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable | From | Juergen Gross <> | Date | Thu, 18 Jul 2019 05:48:34 +0200 |
| |
On 17.07.19 19:22, Joe Perches wrote: > On Wed, 2019-07-17 at 08:49 +0200, Juergen Gross wrote: >> On 17.07.19 08:46, Joe Perches wrote: >>> On Tue, 2019-07-16 at 12:26 +0800, Zhenzhong Duan wrote: >>>> .. as "nopv" support needs it to be changeable at boot up stage. >>>> >>>> Checkpatch reports warning, so move variable declarations from >>>> hypervisor.c to hypervisor.h >>> [] >>>> diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c >>> [] >>>> @@ -259,7 +259,7 @@ static __init void xen_hvm_guest_late_init(void) >>>> #endif >>>> } >>>> >>>> -const __initconst struct hypervisor_x86 x86_hyper_xen_hvm = { >>>> +struct hypervisor_x86 x86_hyper_xen_hvm __initdata = { >>> >>> static? >> >> It is being referenced from arch/x86/kernel/cpu/hypervisor.c > > But wasn't it also removed from the list of externs? > > Rereading the .h file, no it wasn't. I missed that. > > Perhaps the extern list could be reordered to move this > x86_hyper_xen_hvm to be next to x86_hyper_type. > > I also suggest that "extern bool nopv" might be a bit > non-specific and could use a longer identifier.
You are a little bit late. It has been this way since V5 of the series posted on July 3rd.
I have pushed the series to my tree already and I'm about to send the pull request.
Followup patches welcome. :-)
Juergen
| |