lkml.org 
[lkml]   [2019]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [LINUX PATCH v18 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()
On Tue, 16 Jul 2019 09:31:37 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:

> On Mon, 15 Jul 2019 23:30:51 -0600
> Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> wrote:
>
> > Add check before assigning chip->ecc.read_page() and chip->ecc.write_page()
> >
> > Signed-off-by: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
> > ---
> > Changes in v18
> > - None
> > ---
> > drivers/mtd/nand/raw/nand_micron.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/raw/nand_micron.c b/drivers/mtd/nand/raw/nand_micron.c
> > index cbd4f09ac178..565f2696c747 100644
> > --- a/drivers/mtd/nand/raw/nand_micron.c
> > +++ b/drivers/mtd/nand/raw/nand_micron.c
> > @@ -500,8 +500,11 @@ static int micron_nand_init(struct nand_chip *chip)
> > chip->ecc.size = 512;
> > chip->ecc.strength = chip->base.eccreq.strength;
> > chip->ecc.algo = NAND_ECC_BCH;
> > - chip->ecc.read_page = micron_nand_read_page_on_die_ecc;
> > - chip->ecc.write_page = micron_nand_write_page_on_die_ecc;
> > + if (!chip->ecc.read_page)
> > + chip->ecc.read_page = micron_nand_read_page_on_die_ecc;
> > +
> > + if (!chip->ecc.write_page)
> > + chip->ecc.write_page = micron_nand_write_page_on_die_ecc;
> >
>
> Seriously?! I told you this was inappropriate and you keep sending this
> patch. So let's make it clear:
>
> Nacked-by: Boris Brezillon <boris.brezillon@collabora.com>
>
> Fix your controller driver instead of adding hacks to the Micron logic!

Not even going to review the other patch: if you have to do that, that
means the driver is broken. On a side note, this patch series is still
not threaded as it should be and it's a v18 for a damn NAND controller
driver! Sorry but you reached the limit of my patience. Please find
someone to help you with that task.

\
 
 \ /
  Last update: 2019-07-16 09:45    [W:0.068 / U:2.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site