lkml.org 
[lkml]   [2019]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ocfs2: remove set but not used variable 'last_hash'
From
Date


On 19/7/16 21:21, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> fs/ocfs2/xattr.c: In function ocfs2_xattr_bucket_find:
> fs/ocfs2/xattr.c:3828:6: warning: variable last_hash set but not used [-Wunused-but-set-variable]
>
> It's never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/xattr.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
> index 385f3aa..90c830e3 100644
> --- a/fs/ocfs2/xattr.c
> +++ b/fs/ocfs2/xattr.c
> @@ -3825,7 +3825,6 @@ static int ocfs2_xattr_bucket_find(struct inode *inode,
> u16 blk_per_bucket = ocfs2_blocks_per_xattr_bucket(inode->i_sb);
> int low_bucket = 0, bucket, high_bucket;
> struct ocfs2_xattr_bucket *search;
> - u32 last_hash;
> u64 blkno, lower_blkno = 0;
>
> search = ocfs2_xattr_bucket_new(inode);
> @@ -3869,8 +3868,6 @@ static int ocfs2_xattr_bucket_find(struct inode *inode,
> if (xh->xh_count)
> xe = &xh->xh_entries[le16_to_cpu(xh->xh_count) - 1];
>
> - last_hash = le32_to_cpu(xe->xe_name_hash);
> -
> /* record lower_blkno which may be the insert place. */
> lower_blkno = blkno;
>
>

\
 
 \ /
  Last update: 2019-07-17 02:47    [W:0.047 / U:4.200 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site