lkml.org 
[lkml]   [2019]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 2/2] documention: leds: Add multicolor class documentation
From
Date
Dan,

On 7/16/19 9:27 PM, Dan Murphy wrote:
> Jacek
>
> On 7/16/19 2:18 PM, Jacek Anaszewski wrote:
>> Hi Dan,
>>
>> Thanks for the update. I have some nits below, please take a look.
>>
>> On 7/1/19 10:46 PM, Dan Murphy wrote:
[...]

>>> +The user can control the brightness of that RGB group by writing the
>>> parent
>>> +'brightness' control.  Assuming a parent max_brightness of 255 the
>>> user may want
>>> +to dim the LED color group to half.  The user would write a value of
>>> 128 to the
>>> +parent brightness file then the values written to each LED will be
>>> adjusted
>>> +base on this value
>> We probably need to state here that any amendment to color intensity
>> values resets brightness to its max value.
>
> Well that is not true.  Intensity and brightness are two different spaces.

OK, I had to go through the sequence of steps I had on mind.
I had to work it out that colors set under colors directory don't
reflect the iout colors, but are only used for calculating them,
basing on the brightness and max_intensity values.

Effectively, after changing the colors/<color>/intensity the brightness
value will be still valid, since iout color will be recalculated basing
on the currently set brightness and the new color intensity.

> Brightness is for cluster control and intensity is for monochrome LED
> control.
>
> There only relationship is when setting cluster brightness.


--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2019-07-16 22:40    [W:0.042 / U:28.468 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site