lkml.org 
[lkml]   [2019]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] SafeSetID LSM changes for 5.3
On Tue, Jul 16, 2019 at 12:06 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> - Please use the "git pull-request" format and then add any extra
> notes you feel are necessary
>
> Yes, your pull request is *almost* git pull-request, but you seem
> to have actively removed whitespace making it almost illegible. It's
> really hard to pick out the line that has the actual git repository
> address, because it's basically hidden inside one big blob of text.

Extra note on this: you seem to have done "git pull-request" in a wide
window, and then copied-and-pasted it into your MUA.

So the diffstat lines are also very long, and then they line-wrap and
it all looks nasty.

Avoid this by either using a file for the output (that you then edit
for your own added messages), or using a normal 80x25 terminal or
something.

I guess I should ask Junio to add a "--stat=80" to the upstream git
request-pull script.

Linus

\
 
 \ /
  Last update: 2019-07-16 21:16    [W:0.054 / U:12.252 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site