lkml.org 
[lkml]   [2019]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock
From
Date

> On Jul 16, 2019, at 7:05 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Mon, Jul 15, 2019 at 03:25:34PM -0400, Alex Kogan wrote:
>> +/**
>> + * find_successor - Scan the main waiting queue looking for the first
>> + * thread running on the same node as the lock holder. If found (call it
>> + * thread T), move all threads in the main queue between the lock holder
>> + * and T to the end of the secondary queue and return T; otherwise, return NULL.
>> + */
>> +static struct cna_node *find_successor(struct mcs_spinlock *me)
>
> Either don't use a kernel doc comment, but if you must, you have to
> stick to their format, otherwise we'll get endless stupid patches fixing
> up the stupid comment.
Will fix that.

Thanks,
— Alex

\
 
 \ /
  Last update: 2019-07-16 16:32    [W:0.148 / U:57.220 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site