lkml.org 
[lkml]   [2019]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent
From
Date
On 15/07/2019 16:17, Sinan Kaya wrote:
> On 7/15/2019 1:43 AM, Fuqian Huang wrote:
>> Should I rewrite the commit log? Just mention that dma_alloc_coherent
>> has already
>> zeroed the memory and not to reference the commit?
>
> I'd like to hear from Robin Murphy that arm smmu driver follows this as
> well.

I'd be lying if I said it did.

...but only because that's never been part of the SMMU driver's
responsibility either way. The iommu-dma layer however, and thus the
respective arm64 iommu_dma_ops, has always zeroed allocations right from
its inception.

518a2f1925c3 was just cleaning up the last of the stragglers which
*weren't* already clearing buffers anyway, such that we could formalise
that behaviour into the API.

Robin.

\
 
 \ /
  Last update: 2019-07-16 13:36    [W:0.055 / U:9.504 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site