lkml.org 
[lkml]   [2019]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: kpc2000: whitespace and line length cleanup
On Mon, Jul 15, 2019 at 02:21:23PM -0700, john.hubbard@gmail.com wrote:
> From: John Hubbard <jhubbard@nvidia.com>
>
> This commit was created by running indent(1):
> `indent -linux`
>
> ...and then applying some manual corrections and
> cleanup afterward, to keep it sane. No functional changes
> were made.
>
> In addition to whitespace changes, some strings were split,
> but not strings that were likely to be a grep problem
> (in other words, if a user is likely to grep for a string
> within the driver, that should still work in most cases).
>
> A few "void * foo" cases were fixed to be "void *foo".
>
> That was enough to make checkpatch.pl run without errors,
> although note that there are lots of serious warnings
> remaining--but those require functional, not just whitespace
> changes. So those are left for a separate patch.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Simon Sandström <simon@nikanor.nu>
> Cc: Geordan Neukum <gneukum1@gmail.com>
> Cc: Jeremy Sowden <jeremy@azazel.net>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Vandana BN <bnvandana@gmail.com>
> Cc: devel@driverdev.osuosl.org
> Cc: Bharath Vedartham <linux.bhar@gmail.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> drivers/staging/kpc2000/kpc2000_i2c.c | 189 +++++++++++------
> drivers/staging/kpc2000/kpc2000_spi.c | 116 +++++-----
> drivers/staging/kpc2000/kpc_dma/dma.c | 109 ++++++----
> drivers/staging/kpc2000/kpc_dma/fileops.c | 199 +++++++++++-------
> .../staging/kpc2000/kpc_dma/kpc_dma_driver.c | 113 +++++-----
> .../staging/kpc2000/kpc_dma/kpc_dma_driver.h | 156 +++++++-------
> 6 files changed, 509 insertions(+), 373 deletions(-)

THat's way too many different types of changes to do all at once, and
some of these are making the code look worse, not better.

There's a reason we don't run lindent :)

If you want to do one-type-of-fix-per-patch, I'll gladly take these,
otherwise, I recommend leaving this for those people learning how to do
development to do.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-07-16 10:40    [W:0.082 / U:20.400 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site