lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.2 073/249] net: stmmac: modify default value of tx-frames
    Date
    From: Biao Huang <biao.huang@mediatek.com>

    [ Upstream commit d2facb4b3983425f6776c24dd678a82dbe673773 ]

    the default value of tx-frames is 25, it's too late when
    passing tstamp to stack, then the ptp4l will fail:

    ptp4l -i eth0 -f gPTP.cfg -m
    ptp4l: selected /dev/ptp0 as PTP clock
    ptp4l: port 1: INITIALIZING to LISTENING on INITIALIZE
    ptp4l: port 0: INITIALIZING to LISTENING on INITIALIZE
    ptp4l: port 1: link up
    ptp4l: timed out while polling for tx timestamp
    ptp4l: increasing tx_timestamp_timeout may correct this issue,
    but it is likely caused by a driver bug
    ptp4l: port 1: send peer delay response failed
    ptp4l: port 1: LISTENING to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED)

    ptp4l tests pass when changing the tx-frames from 25 to 1 with
    ethtool -C option.
    It should be fine to set tx-frames default value to 1, so ptp4l will pass
    by default.

    Signed-off-by: Biao Huang <biao.huang@mediatek.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/stmicro/stmmac/common.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h
    index ceb0d23f5041..c265cc5770e8 100644
    --- a/drivers/net/ethernet/stmicro/stmmac/common.h
    +++ b/drivers/net/ethernet/stmicro/stmmac/common.h
    @@ -251,7 +251,7 @@ struct stmmac_safety_stats {
    #define STMMAC_COAL_TX_TIMER 1000
    #define STMMAC_MAX_COAL_TX_TICK 100000
    #define STMMAC_TX_MAX_FRAMES 256
    -#define STMMAC_TX_FRAMES 25
    +#define STMMAC_TX_FRAMES 1

    /* Packets types */
    enum packets_types {
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-15 17:45    [W:4.256 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site