Messages in this thread | | | Date | Tue, 16 Jul 2019 04:11:02 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v4] PM / wakeup: show wakeup sources stats in sysfs |
| |
On Mon, Jul 15, 2019 at 11:48:27PM +0200, Rafael J. Wysocki wrote: > On Mon, Jul 15, 2019 at 11:44 PM Tri Vo <trong@android.com> wrote: > > > > Userspace can use wakeup_sources debugfs node to plot history of suspend > > blocking wakeup sources over device's boot cycle. This information can > > then be used (1) for power-specific bug reporting and (2) towards > > attributing battery consumption to specific processes over a period of > > time. > > > > However, debugfs doesn't have stable ABI. For this reason, create a > > 'struct device' to expose wakeup sources statistics in sysfs under > > /sys/class/wakeup/<name>/. > > > > Introduce CONFIG_PM_SLEEP_STATS that enables/disables showing wakeup > > source statistics in sysfs. > > I'm not sure if this is really needed, but I'll let Greg decide.
You are right. Having zillions of config options is a pain, who is going to turn this off?
But we can always remove the option before 5.4-rc1, so I'll take this as-is for now :)
> Apart from this > > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
thanks for the review! I'll wait for 5.3-rc1 to come out before adding this to my tree.
greg k-h
| |