lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 066/158] ASoC: meson: axg-tdm: fix sample clock inversion
    Date
    From: Jerome Brunet <jbrunet@baylibre.com>

    [ Upstream commit cb36ff785e868992e96e8b9e5a0c2822b680a9e2 ]

    The content of SND_SOC_DAIFMT_FORMAT_MASK is a number, not a bitfield,
    so the test to check if the format is i2s is wrong. Because of this the
    clock setting may be wrong. For example, the sample clock gets inverted
    in DSP B mode, when it should not.

    Fix the lrclk invert helper function

    Fixes: 1a11d88f499c ("ASoC: meson: add tdm formatter base driver")
    Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/meson/axg-tdm.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/meson/axg-tdm.h b/sound/soc/meson/axg-tdm.h
    index e578b6f40a07..5774ce0916d4 100644
    --- a/sound/soc/meson/axg-tdm.h
    +++ b/sound/soc/meson/axg-tdm.h
    @@ -40,7 +40,7 @@ struct axg_tdm_iface {

    static inline bool axg_tdm_lrclk_invert(unsigned int fmt)
    {
    - return (fmt & SND_SOC_DAIFMT_I2S) ^
    + return ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) == SND_SOC_DAIFMT_I2S) ^
    !!(fmt & (SND_SOC_DAIFMT_IB_IF | SND_SOC_DAIFMT_NB_IF));
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-15 17:45    [W:4.243 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site