lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.4 42/53] x86/build: Add 'set -e' to mkcapflags.sh to delete broken capflags.c
    Date
    From: Masahiro Yamada <yamada.masahiro@socionext.com>

    [ Upstream commit bc53d3d777f81385c1bb08b07bd1c06450ecc2c1 ]

    Without 'set -e', shell scripts continue running even after any
    error occurs. The missed 'set -e' is a typical bug in shell scripting.

    For example, when a disk space shortage occurs while this script is
    running, it actually ends up with generating a truncated capflags.c.

    Yet, mkcapflags.sh continues running and exits with 0. So, the build
    system assumes it has succeeded.

    It will not be re-generated in the next invocation of Make since its
    timestamp is newer than that of any of the source files.

    Add 'set -e' so that any error in this script is caught and propagated
    to the build system.

    Since 9c2af1c7377a ("kbuild: add .DELETE_ON_ERROR special target"),
    make automatically deletes the target on any failure. So, the broken
    capflags.c will be deleted automatically.

    Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Link: https://lkml.kernel.org/r/20190625072622.17679-1-yamada.masahiro@socionext.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/x86/kernel/cpu/mkcapflags.sh | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/x86/kernel/cpu/mkcapflags.sh b/arch/x86/kernel/cpu/mkcapflags.sh
    index 6988c74409a8..711b74e0e623 100644
    --- a/arch/x86/kernel/cpu/mkcapflags.sh
    +++ b/arch/x86/kernel/cpu/mkcapflags.sh
    @@ -3,6 +3,8 @@
    # Generate the x86_cap/bug_flags[] arrays from include/asm/cpufeatures.h
    #

    +set -e
    +
    IN=$1
    OUT=$2

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-15 17:45    [W:3.213 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site