lkml.org 
[lkml]   [2019]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.4 29/53] bpf: silence warning messages in core
    Date
    From: Valdis Klētnieks <valdis.kletnieks@vt.edu>

    [ Upstream commit aee450cbe482a8c2f6fa5b05b178ef8b8ff107ca ]

    Compiling kernel/bpf/core.c with W=1 causes a flood of warnings:

    kernel/bpf/core.c:1198:65: warning: initialized field overwritten [-Woverride-init]
    1198 | #define BPF_INSN_3_TBL(x, y, z) [BPF_##x | BPF_##y | BPF_##z] = true
    | ^~~~
    kernel/bpf/core.c:1087:2: note: in expansion of macro 'BPF_INSN_3_TBL'
    1087 | INSN_3(ALU, ADD, X), \
    | ^~~~~~
    kernel/bpf/core.c:1202:3: note: in expansion of macro 'BPF_INSN_MAP'
    1202 | BPF_INSN_MAP(BPF_INSN_2_TBL, BPF_INSN_3_TBL),
    | ^~~~~~~~~~~~
    kernel/bpf/core.c:1198:65: note: (near initialization for 'public_insntable[12]')
    1198 | #define BPF_INSN_3_TBL(x, y, z) [BPF_##x | BPF_##y | BPF_##z] = true
    | ^~~~
    kernel/bpf/core.c:1087:2: note: in expansion of macro 'BPF_INSN_3_TBL'
    1087 | INSN_3(ALU, ADD, X), \
    | ^~~~~~
    kernel/bpf/core.c:1202:3: note: in expansion of macro 'BPF_INSN_MAP'
    1202 | BPF_INSN_MAP(BPF_INSN_2_TBL, BPF_INSN_3_TBL),
    | ^~~~~~~~~~~~

    98 copies of the above.

    The attached patch silences the warnings, because we *know* we're overwriting
    the default initializer. That leaves bpf/core.c with only 6 other warnings,
    which become more visible in comparison.

    Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
    Acked-by: Andrii Nakryiko <andriin@fb.com>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/bpf/Makefile | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/kernel/bpf/Makefile b/kernel/bpf/Makefile
    index 13272582eee0..677991f29d66 100644
    --- a/kernel/bpf/Makefile
    +++ b/kernel/bpf/Makefile
    @@ -1,4 +1,5 @@
    obj-y := core.o
    +CFLAGS_core.o += $(call cc-disable-warning, override-init)

    obj-$(CONFIG_BPF_SYSCALL) += syscall.o verifier.o inode.o helpers.o
    obj-$(CONFIG_BPF_SYSCALL) += hashtab.o arraymap.o
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-07-15 17:45    [W:4.080 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site