lkml.org 
[lkml]   [2019]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 2/4] iio: cros_ec_accel_legacy: Fix incorrect channel setting
    On Fri, 28 Jun 2019 12:17:09 -0700
    Gwendal Grignou <gwendal@chromium.org> wrote:

    > INFO_SCALE is set both for each channel and all channels.
    > iio is using all channel setting, so the error was not user visible.
    >
    > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
    This one I am going to take because it is stand alone and I have some other
    fixes queued up for a pull request in a week or so anyway.

    I'm unconvinced this isn't uservisible in general, though perhaps
    userspace code won't use it.

    Thanks,

    Jonathan

    > ---
    > drivers/iio/accel/cros_ec_accel_legacy.c | 1 -
    > 1 file changed, 1 deletion(-)
    >
    > diff --git a/drivers/iio/accel/cros_ec_accel_legacy.c b/drivers/iio/accel/cros_ec_accel_legacy.c
    > index 46bb2e421bb9..ad19d9c716f4 100644
    > --- a/drivers/iio/accel/cros_ec_accel_legacy.c
    > +++ b/drivers/iio/accel/cros_ec_accel_legacy.c
    > @@ -319,7 +319,6 @@ static const struct iio_chan_spec_ext_info cros_ec_accel_legacy_ext_info[] = {
    > .modified = 1, \
    > .info_mask_separate = \
    > BIT(IIO_CHAN_INFO_RAW) | \
    > - BIT(IIO_CHAN_INFO_SCALE) | \
    > BIT(IIO_CHAN_INFO_CALIBBIAS), \
    > .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SCALE), \
    > .ext_info = cros_ec_accel_legacy_ext_info, \

    \
     
     \ /
      Last update: 2019-07-14 18:55    [W:2.744 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site