lkml.org 
[lkml]   [2019]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver
Date

On 7/14/19 12:09 PM, Jonathan Cameron wrote:
> On Thu, 11 Jul 2019 21:16:20 +0900
> William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
>
>> On Thu, Jul 11, 2019 at 02:12:27PM +0200, Benjamin Gaignard wrote:
>>> Le jeu. 11 juil. 2019 à 13:51, William Breathitt Gray
>>> <vilhelm.gray@gmail.com> a écrit :
>>>> On Tue, May 07, 2019 at 11:12:24AM +0200, Benjamin Gaignard wrote:
>>>>> Quadrature feature is now hosted on it own framework.
>>>>> Remove quadrature related code from stm32-trigger driver to avoid
>>>>> code duplication and simplify the ABI.
>>>>>
>>>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>>>> What is the status of this patch? Are there any objections currently for
>>>> its inclusion?
>>> You were the only one asking for more details about it :-)
>>> If you agree I think that Jonathan can merge it.
>>>
>>> Benjamin
>>>> William Breathitt Gray
>>>>
>>>> _______________________________________________
>>>> linux-arm-kernel mailing list
>>>> linux-arm-kernel@lists.infradead.org
>>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>> Yes, Jonathan please merge this if you have no objections, I hadn't
>> realized I was delaying it.
>>
>> Thank you,
>>
>> William Breathitt Gray
> One last thing... This seems to be a userspace ABI change. What
> are our potential issues with users of this ABI?
>
> It's not that costly to keep the code, though dropping the docs or
> putting a depreciated note in them is probably a good idea. Hence
> I'm not totally convinced the risk of a regression is worth it.

As far I know nobody use this interface yet for me there is no risk to
remove this code.

Benjamin

>
> If we think it's the sort of change no one will notice, then
> fair enough we'll give it a go and cross our fingers.
>
> Thanks,
>
> Jonathan
>
>
\
 
 \ /
  Last update: 2019-07-14 17:33    [W:0.080 / U:5.788 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site