lkml.org 
[lkml]   [2019]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] platform/x86: pcengines-apu2 needs gpiolib
From
Date
On 12.07.19 10:54, Arnd Bergmann wrote:

Hi,

> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index e869a5c760b6..cf48b9068843 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1324,8 +1324,8 @@ config PCENGINES_APU2
> tristate "PC Engines APUv2/3 front button and LEDs driver"
> depends on INPUT && INPUT_KEYBOARD
> depends on LEDS_CLASS
> - select GPIO_AMD_FCH
> - select KEYBOARD_GPIO_POLLED
> + select GPIO_AMD_FCH if GPIOLIB
> + select KEYBOARD_GPIO_POLLED if GPIOLIB
> select LEDS_GPIO
> help
> This driver provides support for the front button and LEDs on

That might compile but the driver won't work, if KEYBOARD_GPIO_POLLED
or GPIO_AMD_FCH isn't there.


--mtx

--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

\
 
 \ /
  Last update: 2019-07-13 16:37    [W:0.080 / U:3.612 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site