lkml.org 
[lkml]   [2019]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] [media] media: mtk-mdp: fix reference count on old device tree
    From
    Date


    On Mon, 2019-07-08 at 17:06 +0800, Matthias Brugger wrote:
    >
    > On 21/06/2019 13:32, Matthias Brugger wrote:
    > > of_get_next_child() increments the reference count of the returning
    > > device_node. Decrement it in the check if we are using the old or the
    > > new DTB.
    > >
    > > Fixes: ba1f1f70c2c0 ("[media] media: mtk-mdp: Fix mdp device tree")
    > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
    >
    > Any comments on that?
    >

    Hi Matthias,
    Thanks for fixing the bug. Sorry to reply late~

    Acked-by: Houlong Wei <houlong.wei@mediatek.com>


    > > ---
    > > drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 4 +++-
    > > 1 file changed, 3 insertions(+), 1 deletion(-)
    > >
    > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
    > > index bbb24fb95b95..bafe53c5d54a 100644
    > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
    > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
    > > @@ -118,7 +118,9 @@ static int mtk_mdp_probe(struct platform_device *pdev)
    > > mutex_init(&mdp->vpulock);
    > >
    > > /* Old dts had the components as child nodes */
    > > - if (of_get_next_child(dev->of_node, NULL)) {
    > > + parent = of_get_next_child(dev->of_node, NULL);
    > > + if (parent) {
    > > + of_node_put(parent);
    > > parent = dev->of_node;
    > > dev_warn(dev, "device tree is out of date\n");
    > > } else {
    > >


    \
     
     \ /
      Last update: 2019-07-12 09:24    [W:3.032 / U:0.896 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site