lkml.org 
[lkml]   [2019]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRe: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status
-----"Nathan Chancellor" <natechancellor@gmail.com> wrote: -----

>To: "Bernard Metzler" <bmt@zurich.ibm.com>, "Doug Ledford"
><dledford@redhat.com>, "Jason Gunthorpe" <jgg@ziepe.ca>
>From: "Nathan Chancellor" <natechancellor@gmail.com>
>Date: 07/10/2019 07:48PM
>Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
>clang-built-linux@googlegroups.com, "Nathan Chancellor"
><natechancellor@gmail.com>
>Subject: [EXTERNAL] [PATCH] rdma/siw: Use proper enumerated type in
>map_cqe_status
>
>clang warns several times:
>
>drivers/infiniband/sw/siw/siw_cq.c:31:4: warning: implicit conversion
>from enumeration type 'enum siw_wc_status' to different enumeration
>type
>'enum siw_opcode' [-Wenum-conversion]
> { SIW_WC_SUCCESS, IB_WC_SUCCESS },
> ~ ^~~~~~~~~~~~~~
>
>Fixes: b0fff7317bb4 ("rdma/siw: completion queue methods")
>Link:
>https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Clang
>BuiltLinux_linux_issues_596&d=DwIDAg&c=jf_iaSHvJObTbx-siA1ZOg&r=2TaYX
>Q0T-r8ZO1PP1alNwU_QJcRRLfmYTAgd3QCvqSc&m=1dqKSwiEVgePsLNbxXRmdhXDxww4
>AEGxKq-g-MmQHBo&s=IFwaU5yLu598NLBtKkAxLXzRNmACfnhxCpg3QVeJpB0&e=
>Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>---
> drivers/infiniband/sw/siw/siw_cq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_cq.c
>b/drivers/infiniband/sw/siw/siw_cq.c
>index e2a0ee40d5b5..e381ae9b7d62 100644
>--- a/drivers/infiniband/sw/siw/siw_cq.c
>+++ b/drivers/infiniband/sw/siw/siw_cq.c
>@@ -25,7 +25,7 @@ static int map_wc_opcode[SIW_NUM_OPCODES] = {
> };
>
> static struct {
>- enum siw_opcode siw;
>+ enum siw_wc_status siw;
> enum ib_wc_status ib;
> } map_cqe_status[SIW_NUM_WC_STATUS] = {
> { SIW_WC_SUCCESS, IB_WC_SUCCESS },
>--
>2.22.0
>
>
>
Nathan, thanks very much. That's correct.
I don't know how this could pass w/o warning.

Many thanks,
Bernard.

\
 
 \ /
  Last update: 2019-07-11 09:45    [W:0.045 / U:23.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site