lkml.org 
[lkml]   [2019]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sound: soc: codecs: wcd9335: fix "conversion to bool not needed here"
From
Date
On Thu, 2019-07-11 at 23:19 +0530, Hariprasad Kelam wrote:
> Fix below issue reported by coccicheck
> sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not
> needed here
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> sound/soc/codecs/wcd9335.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> index 1bbbe42..85a8d10 100644
> --- a/sound/soc/codecs/wcd9335.c
> +++ b/sound/soc/codecs/wcd9335.c
> @@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data)
> regmap_read(wcd->if_regmap,
> WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val);
> if (val) {
> - if (!tx)
> - reg = WCD9335_SLIM_PGD_PORT_INT_EN0 +
> - (port_id / 8);
> - else
> - reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 +
> - (port_id / 8);
> + reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8);
> regmap_read(
> wcd->if_regmap, reg, &int_val);
> /*

This change makes no sense and doesn't match the commit message.


\
 
 \ /
  Last update: 2019-07-12 00:01    [W:0.020 / U:8.352 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site