Messages in this thread | | | Subject | Re: [PATCH 2/2] cputime: remove duplicate code in account_process_tick | From | Alex Shi <> | Date | Thu, 11 Jul 2019 14:41:24 +0800 |
| |
在 2019/7/10 下午10:15, Peter Zijlstra 写道: > On Tue, Jul 09, 2019 at 02:01:00PM +0800, Alex Shi wrote: >> In funcation account_process_tick, func actually do same things with >> irqtime_account_process_tick, whenever if IRQ_TIME_ACCOUNTING set or >> if sched_clock_irqtime enabled. >> >> So it's better to reuse one function for both. > > But it's not the exact same.. and you didn't say, not did you say why > that is fine. >
Thanks for reply!
The irqtime_account_process_tick path was introduced for precise ns irq time account(abb74cefa9c682fb sched: Export ns irqtimes through /proc/stat) while account_process_tick still use jiffes. but now both pathes are using ns cputime. And there is not strong reason to keep 2 very very similar path coexists. That's the reason I believe unite the collection is better.
Thanks Alex
| |