lkml.org 
[lkml]   [2019]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH] drm/i915: Drop extern qualifiers from header function prototypes
Date
Hi Chris,

On Wednesday, July 10, 2019 5:01:04 PM CEST Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-07-10 15:52:39)
> > Follow dim checkpatch recommendation so it doesn't complain on that now
> > and again on header file modifications.
> >
> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
>
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2388,19 +2388,18 @@ __i915_printk(struct drm_i915_private *dev_priv,
const char *level,
> > __i915_printk(dev_priv, KERN_ERR, fmt, ##__VA_ARGS__)
> >
> > #ifdef CONFIG_COMPAT
> > -extern long i915_compat_ioctl(struct file *filp, unsigned int cmd,
> > - unsigned long arg);
> > +long i915_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long
arg);
> > #else
> > #define i915_compat_ioctl NULL
> > #endif
> > extern const struct dev_pm_ops i915_pm_ops;
> > +extern const struct dev_pm_ops i915_pm_ops_1;
>
> That's novel.

Oh, sorry, that was my testing of how dim checkpatch reacts on extern
qualifiers on variables. Thanks for catching this.

Janusz

> > -Chris
>




\
 
 \ /
  Last update: 2019-07-11 08:30    [W:0.034 / U:3.608 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site