Messages in this thread | | | Date | Wed, 10 Jul 2019 21:09:50 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3 1/4] leds: Add of_led_get() and led_put() |
| |
On Wed 2019-07-10 14:39:29, Jean-Jacques Hiblot wrote: > From: Tomi Valkeinen <tomi.valkeinen@ti.com> > > This patch adds basic support for a kernel driver to get a LED device. > This will be used by the led-backlight driver. > > Only OF version is implemented for now, and the behavior is similar to > PWM's of_pwm_get() and pwm_put(). > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> @@ -214,6 +215,55 @@ static int led_resume(struct device *dev) > > static SIMPLE_DEV_PM_OPS(leds_class_dev_pm_ops, led_suspend, led_resume); > > +static int led_match_led_node(struct device *led_dev, const void *data) > +{ > + return led_dev->of_node == data ? 1 : 0; > +}
Get rid of the "? 1 : 0"?
> + led_node = of_parse_phandle(np, "leds", index); > + if (!led_node) > + return ERR_PTR(-ENOENT); > + led_dev = class_find_device(leds_class, NULL, led_node, > + led_match_led_node); > + of_node_put(led_node); > + > + if (!led_dev) > + return ERR_PTR(-EPROBE_DEFER);
Won't this defer probe "forever" when the driver is not available?
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |