lkml.org 
[lkml]   [2019]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sound: pci: lx6464es: Remove unneeded variable err
On Wed, 10 Jul 2019 11:49:31 +0200,
Takashi Iwai wrote:
>
> On Wed, 10 Jul 2019 04:30:59 +0200,
> Hariprasad Kelam wrote:
> >
> > This patch fixes below issue reported by coccicheck
> > sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return
> > "0" on line 258
> >
> > We cannot change return value as its registered with snd_pcm_ops->close
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>
> Applied, thanks.

Well, looking at the description above again, I'd drop the text

"We cannot change return value as its registered with
snd_pcm_ops->close"

because this is quite misleading. There is absolutely no need for
changing the function return type.


thanks,

Takashi

\
 
 \ /
  Last update: 2019-07-10 11:53    [W:0.079 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site