lkml.org 
[lkml]   [2019]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:irq/urgent] irqchip/gic-v3-its: Fix misuse of GENMASK macro
    Commit-ID:  20faba848752901de23a4d45a1174d64d2069dde
    Gitweb: https://git.kernel.org/tip/20faba848752901de23a4d45a1174d64d2069dde
    Author: Joe Perches <joe@perches.com>
    AuthorDate: Tue, 9 Jul 2019 22:04:18 -0700
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Wed, 10 Jul 2019 11:04:17 +0200

    irqchip/gic-v3-its: Fix misuse of GENMASK macro

    Arguments are supposed to be ordered high then low.

    Signed-off-by: Joe Perches <joe@perches.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Acked-by: Marc Zyngier <marc.zyngier@arm.com>
    Link: https://lkml.kernel.org/r/ab5deb4fc3cd604cb620054770b7d00016d736bc.1562734889.git.joe@perches.com

    ---
    drivers/irqchip/irq-gic-v3-its.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
    index 35500801dc2b..730fbe0e2a9d 100644
    --- a/drivers/irqchip/irq-gic-v3-its.c
    +++ b/drivers/irqchip/irq-gic-v3-its.c
    @@ -185,7 +185,7 @@ static struct its_collection *dev_event_to_col(struct its_device *its_dev,

    static struct its_collection *valid_col(struct its_collection *col)
    {
    - if (WARN_ON_ONCE(col->target_address & GENMASK_ULL(0, 15)))
    + if (WARN_ON_ONCE(col->target_address & GENMASK_ULL(15, 0)))
    return NULL;

    return col;
    \
     
     \ /
      Last update: 2019-07-10 11:08    [W:2.702 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site