| Subject | Re: [PATCH 05/12] irqchip/gic-v3-its: Fix misuse of GENMASK macro | From | Marc Zyngier <> | Date | Wed, 10 Jul 2019 09:28:29 +0100 |
| |
On 10/07/2019 06:04, Joe Perches wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/irqchip/irq-gic-v3-its.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 35500801dc2b..730fbe0e2a9d 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -185,7 +185,7 @@ static struct its_collection *dev_event_to_col(struct its_device *its_dev, > > static struct its_collection *valid_col(struct its_collection *col) > { > - if (WARN_ON_ONCE(col->target_address & GENMASK_ULL(0, 15))) > + if (WARN_ON_ONCE(col->target_address & GENMASK_ULL(15, 0))) > return NULL; > > return col; >
Well caught.
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Thanks,
M. -- Jazz is not dead. It just smells funny...
|