Messages in this thread | | | Date | Wed, 10 Jul 2019 09:23:49 +0200 | From | Paul Kocialkowski <> | Subject | Re: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro |
| |
Hi,
On Tue 09 Jul 19, 22:04, Joe Perches wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches <joe@perches.com>
Good catch, thanks!
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cheers,
Paul
> --- > drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_regs.h b/drivers/staging/media/sunxi/cedrus/cedrus_regs.h > index 3e9931416e45..ddd29788d685 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_regs.h > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_regs.h > @@ -110,7 +110,7 @@ > #define VE_DEC_MPEG_MBADDR (VE_ENGINE_DEC_MPEG + 0x10) > > #define VE_DEC_MPEG_MBADDR_X(w) (((w) << 8) & GENMASK(15, 8)) > -#define VE_DEC_MPEG_MBADDR_Y(h) (((h) << 0) & GENMASK(0, 7)) > +#define VE_DEC_MPEG_MBADDR_Y(h) (((h) << 0) & GENMASK(7, 0)) > > #define VE_DEC_MPEG_CTRL (VE_ENGINE_DEC_MPEG + 0x14) > > -- > 2.15.0 >
-- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
| |