Messages in this thread | | | Subject | Re: [PATCH] blk-mq: Use seq_puts() in __blk_mq_debugfs_rq_show() | From | Bart Van Assche <> | Date | Mon, 1 Jul 2019 12:47:56 -0700 |
| |
On 7/1/19 12:27 PM, Markus Elfring wrote: > A string which did not contain a data format specification should be put > into a sequence. Thus use the corresponding function “seq_puts”.
"should"? Why should this be done? Or in other words, what is wrong with the current code other than that it is slightly verbose and slightly slower than seq_puts()? Do you think this matters for debugfs code?
Thanks,
Bart.
| |