lkml.org 
[lkml]   [2019]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] blk-mq: Use seq_puts() in __blk_mq_debugfs_rq_show()
From
Date
On 7/1/19 12:27 PM, Markus Elfring wrote:
> A string which did not contain a data format specification should be put
> into a sequence. Thus use the corresponding function “seq_puts”.

"should"? Why should this be done? Or in other words, what is wrong with
the current code other than that it is slightly verbose and slightly
slower than seq_puts()? Do you think this matters for debugfs code?

Thanks,

Bart.

\
 
 \ /
  Last update: 2019-07-01 21:48    [W:0.040 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site