Messages in this thread | | | From | "Sa, Nuno" <> | Subject | Re: [PATCH] spi: spi-bcm2835.c: Fix 3-wire mode | Date | Mon, 1 Jul 2019 14:21:21 +0000 |
| |
On Mon, 2019-07-01 at 13:55 +0200, Lukas Wunner wrote: > I see. In that case, try: > > /* handle all the 3-wire mode */ > - if ((spi->mode & SPI_3WIRE) && (tfr->rx_buf)) > + if ((spi->mode & SPI_3WIRE) && (tfr->rx_buf != ctlr->dummy_rx)) > cs |= BCM2835_SPI_CS_REN; > else > cs &= ~BCM2835_SPI_CS_REN; >
This worked fine. Also, I did a quick backport of the state of your driver's (both spi-bcm2835 and bcm2835-dma) in revpi_staging and it also worked fine with my device. So, as far as I understand, the above suggestion (or my patch) is not intended to be upstreamed, right? It is just a temporary fix that I can use while your patchset gets upstream.
Thanks for your help! Nuno Sá
| |