Messages in this thread | | | Date | Mon, 1 Jul 2019 09:17:57 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH] mtd: onenand_base: Mark expected switch fall-through |
| |
Hi Gustavo,
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote on Tue, 4 Jun 2019 09:17:37 -0500:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/mtd/nand/onenand/onenand_base.c: In function ‘onenand_check_features’: > drivers/mtd/nand/onenand/onenand_base.c:3264:17: warning: this statement may fall through [-Wimplicit-fallthrough=] > this->options |= ONENAND_HAS_NOP_1; > drivers/mtd/nand/onenand/onenand_base.c:3265:2: note: here > case ONENAND_DEVICE_DENSITY_4Gb: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Cc: Jonathan Bakker <xc-racer2@live.ca> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/mtd/nand/onenand/onenand_base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/onenand/onenand_base.c b/drivers/mtd/nand/onenand/onenand_base.c > index ba46d0cf60a1..bdb5f4733d28 100644 > --- a/drivers/mtd/nand/onenand/onenand_base.c > +++ b/drivers/mtd/nand/onenand/onenand_base.c > @@ -3262,6 +3262,7 @@ static void onenand_check_features(struct mtd_info *mtd) > switch (density) { > case ONENAND_DEVICE_DENSITY_8Gb: > this->options |= ONENAND_HAS_NOP_1; > + /* fall through */ > case ONENAND_DEVICE_DENSITY_4Gb: > if (ONENAND_IS_DDP(this)) > this->options |= ONENAND_HAS_2PLANE;
Applied to nand/next, thanks.
Miquèl
| |