lkml.org 
[lkml]   [2019]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ipv6: exthdrs: fix warning comparison to bool
From
From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Date: Sat, 8 Jun 2019 14:05:33 +0530

> Fix below warning reported by coccicheck
>
> net/ipv6/exthdrs.c:180:9-29: WARNING: Comparison to bool
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
...
> diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
> index ab5add0..e137325 100644
> --- a/net/ipv6/exthdrs.c
> +++ b/net/ipv6/exthdrs.c
> @@ -177,7 +177,7 @@ static bool ip6_parse_tlv(const struct tlvtype_proc *procs,
> /* type specific length/alignment
> checks will be performed in the
> func(). */
> - if (curr->func(skb, off) == false)
> + if (!curr->func(skb, off))

curr->func() returns type 'bool', whats wrong with comparing against the
same type?

I'm not applying stuff like this, sorry.

\
 
 \ /
  Last update: 2019-06-10 04:55    [W:0.053 / U:0.816 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site