lkml.org 
[lkml]   [2019]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net] bonding: make debugging output more succinct
From
From: Jarod Wilson <jarod@redhat.com>
Date: Fri, 7 Jun 2019 11:02:34 -0400

> On 6/7/19 10:59 AM, Jarod Wilson wrote:
>> Seeing bonding debug log data along the lines of "event: 5" is a bit
>> spartan,
>> and often requires a lookup table if you don't remember what every
>> event is.
>> Make use of netdev_cmd_to_name for an improved debugging experience,
>> so for
>> the prior example, you'll see: "bond_netdev_event received
>> NETDEV_REGISTER"
>> instead (both are prefixed with the device for which the event
>> pertains).
>> There are also quite a few places that the netdev_dbg output could
>> stand to
>> mention exactly which slave the message pertains to (gets messy if you
>> have
>> multiple slaves all spewing at once to know which one they pertain
>> to).
>
> Argh. Please drop this one, detritus in my git tree when I hit git
> send-email caused this earlier iteration of patch 1 of the set this is
> threaded with to go out.

Ok.

\
 
 \ /
  Last update: 2019-06-09 22:37    [W:0.065 / U:1.424 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site