lkml.org 
[lkml]   [2019]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/34] leds: leds-pca955x: simplify getting the adapter of a client
From
Date
Hi Wolfram,

Thank you for the patches.

On 6/8/19 12:55 PM, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Please apply to your subsystem tree.
>
> drivers/leds/leds-pca955x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> index a9f5dad55956..460626d81c6a 100644
> --- a/drivers/leds/leds-pca955x.c
> +++ b/drivers/leds/leds-pca955x.c
> @@ -432,7 +432,7 @@ static int pca955x_probe(struct i2c_client *client,
> int ngpios = 0;
>
> chip = &pca955x_chipdefs[id->driver_data];
> - adapter = to_i2c_adapter(client->dev.parent);
> + adapter = client->adapter;
> pdata = dev_get_platdata(&client->dev);
> if (!pdata) {
> pdata = pca955x_get_pdata(client, chip);
>

For both 4/34 and 5/34:

Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2019-06-09 13:04    [W:0.241 / U:4.468 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site