lkml.org 
[lkml]   [2019]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 070/241] ufs: fix braino in ufs_get_inode_gid() for solaris UFS flavour
    Date
    [ Upstream commit 4e9036042fedaffcd868d7f7aa948756c48c637d ]

    To choose whether to pick the GID from the old (16bit) or new (32bit)
    field, we should check if the old gid field is set to 0xffff. Mainline
    checks the old *UID* field instead - cut'n'paste from the corresponding
    code in ufs_get_inode_uid().

    Fixes: 252e211e90ce
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ufs/util.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/ufs/util.h b/fs/ufs/util.h
    index 3f9463f8cf2fa..f877d5cadd981 100644
    --- a/fs/ufs/util.h
    +++ b/fs/ufs/util.h
    @@ -228,7 +228,7 @@ ufs_get_inode_gid(struct super_block *sb, struct ufs_inode *inode)
    case UFS_UID_44BSD:
    return fs32_to_cpu(sb, inode->ui_u3.ui_44.ui_gid);
    case UFS_UID_EFT:
    - if (inode->ui_u1.oldids.ui_suid == 0xFFFF)
    + if (inode->ui_u1.oldids.ui_sgid == 0xFFFF)
    return fs32_to_cpu(sb, inode->ui_u3.ui_sun.ui_gid);
    /* Fall through */
    default:
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-06-09 19:13    [W:4.124 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site