lkml.org 
[lkml]   [2019]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 158/241] arm64: cpu_ops: fix a leaked reference by adding missing of_node_put
    Date
    [ Upstream commit 92606ec9285fb84cd9b5943df23f07d741384bfc ]

    The call to of_get_next_child returns a node pointer with refcount
    incremented thus it must be explicitly decremented after the last
    usage.

    Detected by coccinelle with the following warnings:
    ./arch/arm64/kernel/cpu_ops.c:102:1-7: ERROR: missing of_node_put;
    acquired a node pointer with refcount incremented on line 69, but
    without a corresponding object release within this function.

    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Will Deacon <will.deacon@arm.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/kernel/cpu_ops.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c
    index b6bd7d4477683..fbd6aead48e10 100644
    --- a/arch/arm64/kernel/cpu_ops.c
    +++ b/arch/arm64/kernel/cpu_ops.c
    @@ -73,6 +73,7 @@ static const char *__init cpu_read_enable_method(int cpu)
    pr_err("%s: missing enable-method property\n",
    dn->full_name);
    }
    + of_node_put(dn);
    } else {
    enable_method = acpi_get_enable_method(cpu);
    if (!enable_method)
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-06-09 19:10    [W:4.070 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site