lkml.org 
[lkml]   [2019]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 007/241] ALSA: usb-audio: Fix a memory leak bug
    Date
    From: Wenwen Wang <wang6495@umn.edu>

    commit cb5173594d50c72b7bfa14113dfc5084b4d2f726 upstream.

    In parse_audio_selector_unit(), the string array 'namelist' is allocated
    through kmalloc_array(), and each string pointer in this array, i.e.,
    'namelist[]', is allocated through kmalloc() in the following for loop.
    Then, a control instance 'kctl' is created by invoking snd_ctl_new1(). If
    an error occurs during the creation process, the string array 'namelist',
    including all string pointers in the array 'namelist[]', should be freed,
    before the error code ENOMEM is returned. However, the current code does
    not free 'namelist[]', resulting in memory leaks.

    To fix the above issue, free all string pointers 'namelist[]' in a loop.

    Signed-off-by: Wenwen Wang <wang6495@umn.edu>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/usb/mixer.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/sound/usb/mixer.c
    +++ b/sound/usb/mixer.c
    @@ -2112,6 +2112,8 @@ static int parse_audio_selector_unit(str
    kctl = snd_ctl_new1(&mixer_selectunit_ctl, cval);
    if (! kctl) {
    usb_audio_err(state->chip, "cannot malloc kcontrol\n");
    + for (i = 0; i < desc->bNrInPins; i++)
    + kfree(namelist[i]);
    kfree(namelist);
    kfree(cval);
    return -ENOMEM;

    \
     
     \ /
      Last update: 2019-06-09 18:57    [W:2.514 / U:1.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site