lkml.org 
[lkml]   [2019]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.14 00/69] 4.14.124-stable review
On Fri, Jun 07, 2019 at 05:35:09PM +0100, Ben Hutchings wrote:
> On Fri, 2019-06-07 at 09:27 -0700, Guenter Roeck wrote:
> > On Fri, Jun 07, 2019 at 06:16:27PM +0200, Greg Kroah-Hartman wrote:
> > > On Fri, Jun 07, 2019 at 09:11:02AM -0700, Guenter Roeck wrote:
> > > > On Fri, Jun 07, 2019 at 05:38:41PM +0200, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 4.14.124 release.
> > > > > There are 69 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Sun 09 Jun 2019 03:37:08 PM UTC.
> > > > > Anything received after that time might be too late.
> > > > >
> > > >
> > > > fs/btrfs/inode.c: In function 'btrfs_add_link':
> > > > fs/btrfs/inode.c:6590:27: error: invalid initializer
> > > >    struct timespec64 now = current_time(&parent_inode->vfs_inode);
> > > >                            ^~~~~~~~~~~~
>
> For 4.14 the type of "now" should be struct timespec.
>
> > > > fs/btrfs/inode.c:6592:35: error: incompatible types when assigning to type 'struct timespec' from type 'struct timespec64'
> > > >    parent_inode->vfs_inode.i_mtime = now;
> > > >                                    ^
> > > > fs/btrfs/inode.c:6593:35: error: incompatible types when assigning to type 'struct timespec' from type 'struct timespec64'
> > > >    parent_inode->vfs_inode.i_ctime = now;
> > > >                                    ^
> > >
> > > What arch?  This builds for me here.  odd...
> > >
> >
> > arm, i386, m68k, mips, parisc, xtensa, ppc, sh4
> >
> > It was originally seen with v4.14.123-69-gcc46c1204f89 last night,
> > but I confirmed that v4.14.123-70-g94c5316fb246 is still affected.
>
> All 32-bit architectures are affected; on 64-bit architectures
> timespec64 is a macro expanding to timespec.

Thanks, I've made this fix now. Will go push out a -rc2 with it in it.

greg k-h

\
 
 \ /
  Last update: 2019-06-08 11:29    [W:0.808 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site