Messages in this thread | | | Date | Fri, 7 Jun 2019 18:37:23 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 5/6] x86/MCE: Save MCA control bits that get set in hardware |
| |
On Fri, Jun 07, 2019 at 02:49:42PM +0000, Ghannam, Yazen wrote: > Would you mind if the function name stayed the same? The reason is > that MCA_CTL is written here, which is the "init" part, and MCA_STATUS > is cleared. > > I can use another name for the check, e.g. __mcheck_cpu_check_banks() > or __mcheck_cpu_banks_check_init().
Nevermind, leave it as is. I'll fix it up ontop. I don't like that "__mcheck_cpu_init" prefixing there which is a mouthful and should simply be "mce_cpu_<do_stuff>" to denote that it is a function which is run on a CPU to setup stuff.
Thx.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |