lkml.org 
[lkml]   [2019]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 06/12] btrfs-progs: avoid writing super block to sequential zones
Date
It is not possible to write a super block copy in sequential write required
zones as this prevents in-place updates required for super blocks. This
patch limits super block possible locations to zones accepting random
writes. In particular, the zone containing the first block of the device or
partition being formatted must accept random writes.

Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
---
disk-io.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/disk-io.c b/disk-io.c
index 151eb3b5a278..74a4346cbca7 100644
--- a/disk-io.c
+++ b/disk-io.c
@@ -1609,6 +1609,7 @@ static int write_dev_supers(struct btrfs_fs_info *fs_info,
struct btrfs_super_block *sb,
struct btrfs_device *device)
{
+ struct btrfs_zone_info *zinfo = &device->zinfo;
u64 bytenr;
u32 crc;
int i, ret;
@@ -1631,6 +1632,14 @@ static int write_dev_supers(struct btrfs_fs_info *fs_info,
BTRFS_SUPER_INFO_SIZE - BTRFS_CSUM_SIZE);
btrfs_csum_final(crc, &sb->csum[0]);

+ if (!zone_is_random_write(zinfo, fs_info->super_bytenr)) {
+ errno = -EIO;
+ error(
+ "failed to write super block for devid %llu: require random write zone: %m",
+ device->devid);
+ return -EIO;
+ }
+
/*
* super_copy is BTRFS_SUPER_INFO_SIZE bytes and is
* zero filled, we can use it directly
@@ -1659,6 +1668,8 @@ static int write_dev_supers(struct btrfs_fs_info *fs_info,
bytenr = btrfs_sb_offset(i);
if (bytenr + BTRFS_SUPER_INFO_SIZE > device->total_bytes)
break;
+ if (!zone_is_random_write(zinfo, bytenr))
+ continue;

btrfs_set_super_bytenr(sb, bytenr);

--
2.21.0
\
 
 \ /
  Last update: 2019-06-07 15:18    [W:0.253 / U:0.568 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site