lkml.org 
[lkml]   [2019]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 08/19] btrfs: make unmirroed BGs readonly only if we have at least one writable BG
Date
If the btrfs volume has mirrored block groups, it unconditionally makes
un-mirrored block groups read only. When we have mirrored block groups, but
don't have writable block groups, this will drop all writable block groups.
So, check if we have at least one writable mirrored block group before
setting un-mirrored block groups read only.

Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
---
fs/btrfs/extent-tree.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index ebd0d6eae038..3d41d840fe5c 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -10791,6 +10791,9 @@ int btrfs_read_block_groups(struct btrfs_fs_info *info)
}

list_for_each_entry_rcu(space_info, &info->space_info, list) {
+ bool has_rw = false;
+ int i;
+
if (!(get_alloc_profile(info, space_info->flags) &
(BTRFS_BLOCK_GROUP_RAID10 |
BTRFS_BLOCK_GROUP_RAID1 |
@@ -10798,6 +10801,25 @@ int btrfs_read_block_groups(struct btrfs_fs_info *info)
BTRFS_BLOCK_GROUP_RAID6 |
BTRFS_BLOCK_GROUP_DUP)))
continue;
+
+ /* check if we have at least one writable mirroed block group */
+ for (i = 0; i < BTRFS_NR_RAID_TYPES; i++) {
+ if (i == BTRFS_RAID_RAID0 || i == BTRFS_RAID_SINGLE)
+ continue;
+ list_for_each_entry(cache, &space_info->block_groups[i],
+ list) {
+ if (!cache->ro) {
+ has_rw = true;
+ break;
+ }
+ }
+ if (has_rw)
+ break;
+ }
+
+ if (!has_rw)
+ continue;
+
/*
* avoid allocating from un-mirrored block group if there are
* mirrored block groups.
--
2.21.0
\
 
 \ /
  Last update: 2019-06-07 15:11    [W:0.213 / U:11.788 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site