Messages in this thread | | | Subject | Re: [PATCH V5] drivers: i2c: tegra: fix warning/check/error | From | Bitan Biswas <> | Date | Fri, 7 Jun 2019 04:43:26 -0700 |
| |
On 6/6/19 11:03 PM, Wolfram Sang wrote: > On Thu, Jun 06, 2019 at 10:25:03PM -0700, Bitan Biswas wrote: >> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c >> >> Ignore checkpatch WARNING for 80 character line limit at >> places where renaming fields compromises readability. >> >> Delay of approximately 1msec in flush i2c FIFO polling loop >> achieved by usleep_range call as msleep can take 20msecs. >> >> Remove redundant BUG_ON calls or replace with WARN_ON_ONCE >> as needed. Replace BUG() with error handling code. >> Define I2C_ERR_UNEXPECTED_STATUS for error handling. > > You removed the word checkpatch from $subject, but you still did not > split up the patch into logical pieces. The description above already > outlines what those logical pieces could be. > I shall split the patch into multiple logical patches.
-Thanks, Bitan
| |