lkml.org 
[lkml]   [2019]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 02/12] misc: xilinx-sdfec: add core driver
On Thu, Jun 06, 2019 at 06:16:48PM +0000, Dragan Cvetic wrote:
> >
> > > +
> > > + misc_deregister(&xsdfec->miscdev);
> > > + atomic_dec(&xsdfec_ndevs);
> > > + return 0;
> >
> > You free nothing?
> >
> > You are leaking resources like crazy here, this is not ok at all.
>
> The managed resources are used.
> Anyway, I'll test for memory leak and search for the answer.

Oops, no, you are right, I missed the "devm" prefix on those calls. My
fault.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-06-06 21:05    [W:0.049 / U:15.500 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site