lkml.org 
[lkml]   [2019]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] habanalabs: add rate-limit to an error message
From
Date
On Thu, 2019-06-06 at 15:20 +0300, Oded Gabbay wrote:
> This patch changes the print of an error message about mis-configuration
> of the debug infrastructure to be rate-limited, to prevent flooding of
> kernel log, as these configuration requests can come at a high rate.
[]
> diff --git a/drivers/misc/habanalabs/habanalabs_ioctl.c b/drivers/misc/habanalabs/habanalabs_ioctl.c
[]
> @@ -255,7 +255,7 @@ static int hl_debug_ioctl(struct hl_fpriv *hpriv, void *data)
> case HL_DEBUG_OP_SPMU:
> case HL_DEBUG_OP_TIMESTAMP:
> if (!hdev->in_debug) {
> - dev_err(hdev->dev,
> + dev_err_ratelimited(hdev->dev,
> "Rejecting debug configuration request because device not in debug mode\n");
> return -EFAULT;
> }

Perhaps this should be dev_dbg


\
 
 \ /
  Last update: 2019-06-06 20:55    [W:0.063 / U:1.312 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site