lkml.org 
[lkml]   [2019]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] Redundant steps removal and bug fix of ntb_hw_switchtec
Date
Hi, Everyone,

This patch series remove redundant steps and fix one bug of the
ntb_hw_switchtec module.

When a re-initialization is caused by a link event, the driver will
re-setup the shared memory windows. But at that time, the shared memory
is still valid, and it's unnecessary to free, reallocate and then
initialize it again. Remove these redundant steps.

In case of NTB crosslink topology, the setting of shared memory window
in the virtual partition doesn't reset on peer's reboot. So skip the
re-setup of shared memory window for that case.

Switchtec does not support setting multiple MWs simultaneously. However,
there's a race condition when a re-initialization is caused by a link
event, the driver will re-setup the shared memory window asynchronously
and this races with the client setting up its memory windows on the
link up event. Fix this by ensure do the entire initialization in a work
queue and signal the client once it's done.

Regard,
Kelvin

--

Changed since v1:
- It's a second resend of v1

--

Joey Zhang (2):
ntb_hw_switchtec: Remove redundant steps of
switchtec_ntb_reinit_peer() function
ntb_hw_switchtec: Fix setup MW with failure bug

Wesley Sheng (1):
ntb_hw_switchtec: Skip unnecessary re-setup of shared memory window
for crosslink case

drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 80 +++++++++++++++++++++-------------
1 file changed, 49 insertions(+), 31 deletions(-)

--
2.7.4

\
 
 \ /
  Last update: 2019-06-06 09:10    [W:0.059 / U:9.076 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site