lkml.org 
[lkml]   [2019]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 01/12] net: hns3: log detail error info of ROCEE ECC and AXI errors
From
From: Huazhong Tan <tanhuazhong@huawei.com>
Date: Thu, 6 Jun 2019 16:20:56 +0800

> +static int hclge_log_rocee_axi_error(struct hclge_dev *hdev)
> +{
...
> + ret = hclge_cmd_send(&hdev->hw, &desc[0], 3);
> + if (ret) {
> + dev_err(dev, "failed(%d) to query ROCEE AXI error sts\n", ret);
> + return ret;
> + }
...
> + ret = hclge_log_rocee_axi_error(hdev);
> + if (ret) {
> + dev_err(dev, "failed(%d) to process axi error\n", ret);

You log the error twice which is unnecessary.

\
 
 \ /
  Last update: 2019-06-06 19:36    [W:0.104 / U:2.156 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site