lkml.org 
[lkml]   [2019]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 5/7] clk: raspberrypi: register platform device for raspberrypi-cpufreq
From
Date
Quoting Nicolas Saenz Julienne (2019-06-06 10:16:56)
> On Thu, 2019-06-06 at 10:05 -0700, Stephen Boyd wrote:
> > Quoting Nicolas Saenz Julienne (2019-06-06 07:22:58)
> > > diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-
> > > raspberrypi.c
> > > index b1365cf19f3a..052296b5fbe4 100644
> > > --- a/drivers/clk/bcm/clk-raspberrypi.c
> > > +++ b/drivers/clk/bcm/clk-raspberrypi.c
> > > @@ -63,6 +63,8 @@ struct raspberrypi_firmware_prop {
> > > __le32 disable_turbo;
> > > } __packed;
> > >
> > > +static struct platform_device *rpi_cpufreq;
> >
> > Why can't this be stored in platform driver data?
>
> It actually could, I just followed the same pattern as the code found in patch
> #3. I'll update it in the next version if you prefer it.
>

Yes please. It reduces global state.

\
 
 \ /
  Last update: 2019-06-06 19:21    [W:0.078 / U:3.504 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site