lkml.org 
[lkml]   [2019]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] KVM: x86: introduce is_pae_paging
On Thu, Jun 06, 2019 at 06:52:52PM +0200, Paolo Bonzini wrote:
> Checking for 32-bit PAE is quite common around code that fiddles with
> the PDPTRs. Add a function to compress all checks into a single
> invocation.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

I considered adding this helper as well, but shied away because I thought
it might lead to incorrect code, e.g. using is_pae_paging() when is_pae()
is needed. But, looking at the patch, it's definitely cleaner, so:

Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>

\
 
 \ /
  Last update: 2019-06-06 19:21    [W:0.033 / U:22.868 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site