lkml.org 
[lkml]   [2019]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR
    > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in
    > spi and i2c mode.
    >
    > The LSM6DSO and LSM6DSR are also i3c capable so lets give i3c support to
    > them.
    >
    > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
    > ---

    Hi Vitor,

    just a nit inline, but you can add my acked-by for st_lsm6dsx part in v3

    Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

    Regards,
    Lorenzo

    > Changes in v2:
    > Add support for LSM6DSR
    > Set pm_ops to st_lsm6dsx_pm_ops
    >
    > drivers/iio/imu/st_lsm6dsx/Kconfig | 8 ++-
    > drivers/iio/imu/st_lsm6dsx/Makefile | 1 +
    > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c | 76 +++++++++++++++++++++++++++++
    > 3 files changed, 84 insertions(+), 1 deletion(-)
    > create mode 100644 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
    >
    > diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig
    > index 002a423..8115936 100644
    > --- a/drivers/iio/imu/st_lsm6dsx/Kconfig
    > +++ b/drivers/iio/imu/st_lsm6dsx/Kconfig
    > @@ -2,11 +2,12 @@
    >
    > config IIO_ST_LSM6DSX
    > tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors"
    > - depends on (I2C || SPI)
    > + depends on (I2C || SPI || I3C)
    > select IIO_BUFFER
    > select IIO_KFIFO_BUF
    > select IIO_ST_LSM6DSX_I2C if (I2C)
    > select IIO_ST_LSM6DSX_SPI if (SPI_MASTER)
    > + select IIO_ST_LSM6DSX_I3C if (I3C)
    > help
    > Say yes here to build support for STMicroelectronics LSM6DSx imu
    > sensor. Supported devices: lsm6ds3, lsm6ds3h, lsm6dsl, lsm6dsm,
    > @@ -24,3 +25,8 @@ config IIO_ST_LSM6DSX_SPI
    > tristate
    > depends on IIO_ST_LSM6DSX
    > select REGMAP_SPI
    > +

    [...]

    > +#include <linux/kernel.h>
    > +#include <linux/module.h>
    > +#include <linux/i3c/device.h>
    > +#include <linux/i3c/master.h>
    > +#include <linux/slab.h>
    > +#include <linux/of.h>
    > +#include <linux/regmap.h>
    > +
    > +#include "st_lsm6dsx.h"
    > +
    > +#define NAME_SIZE 32
    > +
    > +struct st_lsm6dsx_i3c_data {
    > + const char name[NAME_SIZE];
    > + enum st_lsm6dsx_hw_id id;
    > +};
    > +
    > +enum st_lsm6dsx_i3c_data_id {
    > + ST_LSM6DSO_I3C_DATA_ID,
    > + ST_LSM6DSR_I3C_DATA_ID,
    > +};

    do we really need them? maybe just use hw_data[n] adding a comment to indicate
    the related sensor defining st_lsm6dsx_i3c_ids[]

    > +
    > +static const struct st_lsm6dsx_i3c_data hw_data[] = {
    > + { ST_LSM6DSO_DEV_NAME, ST_LSM6DSO_ID },
    > + { ST_LSM6DSR_DEV_NAME, ST_LSM6DSR_ID },
    > +};
    > +
    > +static const struct regmap_config st_lsm6dsx_i3c_regmap_config = {
    > + .reg_bits = 8,
    > + .val_bits = 8,
    > +};
    > +
    > +static int st_lsm6dsx_i3c_probe(struct i3c_device *i3cdev)
    > +{
    > + const struct i3c_device_id *id = i3c_get_device_id(i3cdev);
    > + const struct st_lsm6dsx_i3c_data *hw_data = id->data;
    > + struct regmap *regmap;
    > +
    > + regmap = devm_regmap_init_i3c(i3cdev, &st_lsm6dsx_i3c_regmap_config);
    > + if (IS_ERR(regmap)) {
    > + dev_err(&i3cdev->dev, "Failed to register i3c regmap %d\n",
    > + (int)PTR_ERR(regmap));
    > + return PTR_ERR(regmap);
    > + }
    > +
    > + return st_lsm6dsx_probe(&i3cdev->dev, 0, hw_data->id,
    > + hw_data->name, regmap);
    > +}
    > +
    > +static const struct i3c_device_id st_lsm6dsx_i3c_ids[] = {
    > + I3C_DEVICE(0x0104, 0x006C, &hw_data[ST_LSM6DSO_I3C_DATA_ID]),
    > + I3C_DEVICE(0x0104, 0x006B, &hw_data[ST_LSM6DSR_I3C_DATA_ID]),
    > + { /* sentinel */ },
    > +};
    > +MODULE_DEVICE_TABLE(i3c, st_lsm6dsx_i3c_ids);
    > +
    > +static struct i3c_driver st_lsm6dsx_driver = {
    > + .driver = {
    > + .name = "st_lsm6dsx_i3c",
    > + .pm = &st_lsm6dsx_pm_ops,
    > + },
    > + .probe = st_lsm6dsx_i3c_probe,
    > + .id_table = st_lsm6dsx_i3c_ids,
    > +};
    > +module_i3c_driver(st_lsm6dsx_driver);
    > +
    > +MODULE_AUTHOR("Vitor Soares <vitor.soares@synopsys.com>");
    > +MODULE_DESCRIPTION("STMicroelectronics st_lsm6dsx i3c driver");
    > +MODULE_LICENSE("GPL v2");
    > --
    > 2.7.4
    >
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-06-06 18:59    [W:6.390 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site