lkml.org 
[lkml]   [2019]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] media: v4l2-core: fix uninitialized variable error
From
Date
On 6/5/19 11:53 PM, Shuah Khan wrote:
> Fix the following cppcheck error:
>
> Checking drivers/media/v4l2-core/v4l2-ioctl.c ...
> Checking drivers/media/v4l2-core/v4l2-ioctl.c: CONFIG_VIDEO_ADV_DEBUG...
> [drivers/media/v4l2-core/v4l2-ioctl.c:2470]: (error) Uninitialized variable: sd

This is a false report: sd is set by v4l2_device_for_each_subdev before it is used.

I'm dropping this patch.

Regards,

Hans

>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index 333e387bafeb..205addb949ce 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -2445,7 +2445,7 @@ static int v4l_dbg_g_chip_info(const struct v4l2_ioctl_ops *ops,
> #ifdef CONFIG_VIDEO_ADV_DEBUG
> struct video_device *vfd = video_devdata(file);
> struct v4l2_dbg_chip_info *p = arg;
> - struct v4l2_subdev *sd;
> + struct v4l2_subdev *sd = NULL;
> int idx = 0;
>
> switch (p->match.type) {
>

\
 
 \ /
  Last update: 2019-06-06 09:48    [W:0.063 / U:0.304 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site