lkml.org 
[lkml]   [2019]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] block: Drop unlikely before IS_ERR(_OR_NULL)
From
Date
On 05.06.19 18:32, Joe Perches wrote:

> Likely change all of these too:
>
> $ git grep -P '\blikely.*IS_ERR'
> drivers/net/vxlan.c: if (likely(!IS_ERR(rt))) {
> fs/ntfs/lcnalloc.c: if (likely(page && !IS_ERR(page))) {
> fs/ntfs/mft.c: if (likely(!IS_ERR(page))) {
> fs/ntfs/mft.c: if (likely(!IS_ERR(m)))
> fs/ntfs/mft.c: if (likely(!IS_ERR(m))) {
> fs/ntfs/mft.c: if (likely(!IS_ERR(rl2)))
> fs/ntfs/namei.c: if (likely(!IS_ERR(dent_inode))) {
> fs/ntfs/runlist.c: if (likely(!IS_ERR(old_rl)))
> net/openvswitch/datapath.c: if (likely(!IS_ERR(reply))) {
> net/socket.c: if (likely(!IS_ERR(newfile))) {

Good point, thx.

Added that to my cocci script, which I've just sent to lkml.


--mtx

--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

\
 
 \ /
  Last update: 2019-06-05 22:56    [W:1.748 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site