Messages in this thread | | | Subject | Re: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver | From | "Shenhar, Talel" <> | Date | Wed, 5 Jun 2019 17:51:08 +0300 |
| |
On 6/5/2019 3:50 PM, Greg KH wrote: > On Wed, Jun 05, 2019 at 01:52:01PM +0300, Talel Shenhar wrote: >> --- /dev/null >> +++ b/drivers/irqchip/irq-al-fic.c >> @@ -0,0 +1,289 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/** > No need for kernel-doc format style here. done > >> + * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. > "or its affiliates"? You know the answer to this, don't keep us in > suspense. Put the proper copyright holder here please, otherwise this > is totally useless. > > Well, copyright notices are technically useless anyway, but lawyers like > to cargo-cult with the best of them, so it should be correct at the > least.
This is the format we were asked to use and have been using.
I am pinging them with your comment but I am likely not to get immediate response so I'm publishing v3 without changing the "affiliates" for now.
> > thanks, > > greg k-h
| |